Fix propagation of ZREP_INC_FLAG when doing zrep refresh#197
Open
janvrany wants to merge 1 commit intobolthole:masterfrom
Open
Fix propagation of ZREP_INC_FLAG when doing zrep refresh#197janvrany wants to merge 1 commit intobolthole:masterfrom
ZREP_INC_FLAG when doing zrep refresh#197janvrany wants to merge 1 commit intobolthole:masterfrom
Conversation
When doing `zrep refresh`, `ZREP_INC_FLAG` setting (on "refreshing" side)
was (prior this commit) ignored, falling back to default setting.
This is because the value `ZREP_INC_FLAG` was not propagated to the other
("sending") side. One way would be to set it in `/etc/default/zrep` on the
"sending" side - but this is both fiddly and sets it for all (that is,
you cannot have one "refreshing" site using `-i` and the other using `-I`)
Better solution is to simply propagate the setting to the other side,
which is what this commit does.
Member
|
Thank you both for your continued interest in zrep. |
Member
|
Aha. But that doesnt transfer over well when $BBCP is in the way. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing
zrep refresh,ZREP_INC_FLAGsetting (on "refreshing" side) was (prior this commit) ignored, falling back to default setting.This is because the value
ZREP_INC_FLAGwas not propagated to the other ("sending") side. One way would be to set it in/etc/default/zrepon the "sending" side - but this is both fiddly and sets it for all (that is, you cannot have one "refreshing" site using-iand the other using-I)Better solution is to simply propagate the setting to the other side, which is what this commit does.