Skip to content

Add MDMS method and examples#413

Open
hejiaz wants to merge 7 commits into
brainiak:masterfrom
hejiaz:mdms
Open

Add MDMS method and examples#413
hejiaz wants to merge 7 commits into
brainiak:masterfrom
hejiaz:mdms

Conversation

@hejiaz

@hejiaz hejiaz commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

Add multi-dataset multi-subject (MDMS) SRM analysis method and two example files.

@hejiaz hejiaz changed the title Add MDMS method and examples WIP: Add MDMS method and examples Feb 26, 2019
@hejiaz hejiaz changed the title WIP: Add MDMS method and examples Add MDMS method and examples Feb 27, 2019
@hejiaz

hejiaz commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

The pr-check finished successfully on my computer and Princeton Adroit cluster, but the Travis CI build couldn't complete here. It says "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." Also, I don't have the permission to view the output from the Jenkins linux build, so I don't know what happened there.

@hejiaz

hejiaz commented Feb 27, 2019

Copy link
Copy Markdown
Contributor Author

Could anyone take a look?

@lcnature

Copy link
Copy Markdown
Contributor

The linux failure seems to be related to failure of installying scipy... Not sure why. I think it is unrelated to your code.

@hejiaz

hejiaz commented Feb 28, 2019

Copy link
Copy Markdown
Contributor Author

The Travis CI build couldn't complete. It says "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." Did anyone have the same issue before? Is there a way to workaround or ask it to build again with the same code?

@mihaic

mihaic commented Feb 28, 2019

Copy link
Copy Markdown
Member

Any of the @brainiak/committers can restart Travis builds from the Travis website.

@hejiaz

hejiaz commented Mar 1, 2019

Copy link
Copy Markdown
Contributor Author

I checked my permission status and it turns out I don't have the write access to this repo, so I can't restart the build (I couldn't click the restart build button or restart from the console).

@mihaic

mihaic commented Mar 4, 2019

Copy link
Copy Markdown
Member

@hejiaz, I'm sorry I was not clear in my previous comment. I didn't mean that you should be able to restart the build, I meant the member of the committers team.

I can build your branch on my computer. I'll investigate the Travis issue. In the meantime, we should get a review. If no one volunteers, can you suggest someone?

@hejiaz

hejiaz commented Mar 4, 2019

Copy link
Copy Markdown
Contributor Author

@mihaic Thank you! I suggest Mingbo @lcnature as the reviewer.

@mihaic

mihaic commented Feb 24, 2020

Copy link
Copy Markdown
Member

@hejiaz, @lcnature, could you please have another look at this PR?

@lcnature

Copy link
Copy Markdown
Contributor

@hejiaz @mihaic Sorry. It was my fault. I will catch up asap

change `np.int` to `np.int32` to conform to update of numpy.
correct formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants