Use uv in cd workflow#589
Open
davidt0x wants to merge 5 commits into
Open
Conversation
Add the MPICH library directory to the cibuildwheel Linux test environment so mpi4py can load libmpi during wheel tests. Declare tf-keras in the conda runtime requirements because TensorFlow Probability matnormal tests import the tf_keras shim under conda. Validation: git diff --check; uvx cibuildwheel --print-build-identifiers.
Replay any per-rank pytest report logs that were written before mpiexec times out, so CI exposes the underlying rank-level failure instead of only the wrapper timeout. Also handle TimeoutExpired stdout/stderr consistently with subprocess.run(text=True), avoiding the misleading Windows decode AttributeError. Verification: python3 -m py_compile tests/pytest_mpiexec_plugin.py; git diff --check; uvx flake8 --config tests/.flake8 tests/pytest_mpiexec_plugin.py
NumPy 2.4 rejects assigning a length-one array into a scalar element. The HTFA width posterior update indexed Kx1 arrays and assigned the resulting shape-(1,) value into global_posterior_, which caused the cp311 cibuildwheel test to fail in test_htfa.py::test_can_run. Convert the width prior and variance entries to scalars before computing and assigning the posterior width updates. Verification: python3 -m py_compile src/brainiak/factoranalysis/htfa.py tests/pytest_mpiexec_plugin.py; git diff --check; uvx flake8 --config .flake8 src/brainiak/factoranalysis/htfa.py; uvx flake8 --config tests/.flake8 tests/pytest_mpiexec_plugin.py; uvx --from numpy python scalar assignment check
mihaic
approved these changes
Jun 3, 2026
GitHub has deprecated the macos-13 runner image and the jobs are now sitting queued. Replace the Intel macOS entries in the wheel and conda CD matrices with macos-15-intel while keeping macos-14/macos-latest for Apple Silicon coverage. Checked the rest of .github/workflows and no other macos-13 labels remain. Verification: rg -n 'macos-13|macos-15-intel|macos-latest|macos-14' .github/workflows; git diff --check; python3 workflow scan for macos-13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the CD workflow to match the uv-based CI setup.
Changes:
astral-sh/setup-uv@v7in the sdist, wheel, and conda jobs.uv build --sdistinstead ofpipx run build.uvx cibuildwheelinstead of installing it with pip.uvx --from setuptools-scm python -m setuptools_scm.pyproject.tomlnow requires Python >=3.10.