Tags: chaoz23/finicky
Tags
fix(windows): address CodeRabbit review findings - launcher: fix duplicate URL + misplaced args in the no-known-exe fallback; open the URL via ShellExecuteW (util.OpenURLDefault) instead of `cmd /c start`, so URL metacharacters can't be re-tokenized by the shell into commands - main: same injection-safe ShellExecuteW fallback for the single-instance URL hand-off (still guarded so it never relaunches Finicky when it's the default) - launcher: drain child stdout/stderr via CombinedOutput to avoid a pipe deadlock - detect: enumerate StartMenuInternet under both HKCU and HKLM (+dedupe) so per-user browser installs (default Chrome/Edge/Firefox) are detected - window: gate WebView2 Debug mode behind FINICKY_DEBUG (off by default) - main: back off on repeated IPC Accept() errors instead of a tight loop - ci: `copy /Y` so the Windows asset copy step can't prompt/hang - docs: correct the winget id (JohnSterling.Finicky) and make the native build example self-contained Pre-existing patterns shared verbatim with the macOS build (vm/configInfo/lastError races, fatal-error continuation, failed-rules-load handling) are left matching the reference implementation rather than diverged in the Windows files. Refs johnste#542 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
fix: strdup ObjC strings returned across CGo boundary UTF8String pointers into NSString buffers become dangling once the autorelease pool drains. Use strdup so callers own the memory, and pair each call site in Go with C.free via defer. Affected: getSystemInfo, getNSHomeDirectory, getNSCacheDirectory. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PreviousNext