Thread hot Smi BitAnd successors - #90
Merged
Merged
Conversation
Owner
Author
|
Multi-agent review completed across three independent tracks:
The reviewers found no production semantic defect. Their test/reporting findings were addressed in This is an independent subagent review summary, not a formal GitHub approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BitAndsuccessors through Lantern's existing Int32 fast path.LdaSmi8to avoid charging Splay's 2.08 million nonmatching compact loads.Why
Crypto executes 3,158,688
LdaSmi16 -> BitAndpairs and 1,488,595 full-widthLdaSmi -> BitAndpairs. The retained implementation bypasses 4,646,882 indirect successor dispatches while keeping all logical bytecode telemetry unchanged.Broader opcode and split-handler prototypes were rejected because they regressed zero-hit workloads or caused a whole-function LLVM layout phase change. The retained in-arm hybrid adds only 96 native bytes and uses an unlikely side edge so the dominant ordinary decode path remains favored.
Performance
Pinned x86_64, CPU 3, 40+40 paired physical roles:
0.9795x(2.05% faster)0.9710xarith_loop60+60:0.9895x1.0055x0.9881x, Splay1.0095xNo workload crossed the 2% regression ceiling.
Validation
bitwise-andtest262 pass lists: identical at 29 pass / 1 known failgc-threshold=1bitwise-and sweep: identical 29/1 resultdirect-transfers