Repository navigation
fix(v4): skip a record key that converts to __proto__ at the write - #6760
Merged
Merged
Conversation
A key schema can return an object. The record parser compared that object to "__proto__" and only then let the assignment convert it to a string, so a key whose toString answered "__proto__" replaced the output's prototype. The key is now converted once and the guard reads the converted value, in the runtime parser, the compiled record path (whose exhaustive branch had no check at all) and zod/v3.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A record's key schema can return an object, and the parser compared that object to
"__proto__"before the assignment converted it to a string. A key whosetoString()answered"__proto__"passed the guard and then replaced the parsed record's prototype. The key is now converted once, and both the guard and the write use the converted value.The same check is fixed in the compiled record path and in
zod/v3. The compiled exhaustive branch (z.record(z.enum([...]).transform(...))) had no check at all, so even a plain-string"__proto__"produced by a key transform got through there. The runtime already skipped it.Bundle cost is about 20 B gzipped on a record fixture, classic or mini, and nothing for bundles that don't use records. Schema memory is unchanged.