Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

c/{common,image,storage} have been migrated to c/container-libs, which we adapt.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Sep 10, 2025
@openshift-ci openshift-ci bot requested review from hasan4791 and klihub September 10, 2025 08:39
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2025
@saschagrunert saschagrunert force-pushed the container-libs branch 4 times, most recently from 3640329 to 78625f8 Compare September 10, 2025 09:08
@saschagrunert saschagrunert changed the title WIP: Migrate to container-libs Migrate to container-libs Sep 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2025
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@haircommander
Copy link
Member

/hold

just checking the version of podman we'd need to sync to to do this real quick

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2025
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.99%. Comparing base (ecc1c64) to head (b34e997).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9460      +/-   ##
==========================================
- Coverage   67.02%   66.99%   -0.03%     
==========================================
  Files         202      202              
  Lines       28196    28196              
==========================================
- Hits        18897    18890       -7     
- Misses       7707     7716       +9     
+ Partials     1592     1590       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2025
@saschagrunert
Copy link
Member Author

Rebased.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025
@saschagrunert
Copy link
Member Author

Rebased. Can we get this in now @cri-o/cri-o-maintainers ?

@saschagrunert
Copy link
Member Author

/test ci-cgroupv2-integration

@saschagrunert
Copy link
Member Author

/retest

@cri-o/cri-o-maintainers PTAL

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@bitoku
Copy link
Contributor

bitoku commented Oct 16, 2025

Merging this in 1.35 should be good, but want @haircommander to double check.

@bitoku
Copy link
Contributor

bitoku commented Oct 16, 2025

We'll wait for podman 5.7 release, which should be happening in about a week.

`c/{common,image,storage}` have been migrated to c/container-libs, which
we adapt.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@saschagrunert
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2025

@saschagrunert: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ci-cgroupv2-integration b34e997 link true /test ci-cgroupv2-integration
ci/prow/ci-e2e-conmonrs b34e997 link true /test ci-e2e-conmonrs
ci/prow/ci-cgroupv2-e2e-features b34e997 link true /test ci-cgroupv2-e2e-features
ci/prow/ci-fedora-kata b34e997 link true /test ci-fedora-kata
ci/prow/ci-crun-e2e b34e997 link true /test ci-crun-e2e
ci/prow/ci-fedora-integration b34e997 link true /test ci-fedora-integration
ci/prow/ci-cgroupv2-e2e b34e997 link true /test ci-cgroupv2-e2e
ci/prow/ci-fedora-critest b34e997 link true /test ci-fedora-critest
ci/prow/ci-e2e b34e997 link true /test ci-e2e
ci/prow/ci-cgroupv2-e2e-crun b34e997 link true /test ci-cgroupv2-e2e-crun
ci/prow/ci-rhel-e2e b34e997 link true /test ci-rhel-e2e
ci/prow/ci-rhel-critest b34e997 link true /test ci-rhel-critest
ci/prow/e2e-gcp-ovn b34e997 link true /test e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants