Repository navigation
Conversation
Ubuntu's libomp-dev leaves the linker name next to the compiler resource directory, and Clang's -print-file-name prints the bare name. Meson, CMake, and the crate now search that directory after -print-file-name and LIBRARY_PATH.
Install the crates.io crate, the PyPI wheel, the staged-recipes conda recipe, and the release tag, then build this tree with Clang.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building the v0.4.2 tag with system Clang 18 on Ubuntu fails at link time:
libomp-devputslibomp.sonext to the Clang resource directory, andclang -print-file-name=libomp.soprints the bare name. Meson, CMake andbuild.rsnow also search that directory, after-print-file-nameandLIBRARY_PATH.The second commit adds
scripts/prove-published-install.shand a CI job. Itinstalls linkcell from crates.io, the PyPI wheel, the staged-recipes conda
recipe and the release tag, each in a clean prefix, then builds this tree with
Clang. Every route runs the README quickstart and a periodic k-nearest check
against a brute-force image reference on ortho, sheared and triclinic cells.
Locally, we found that the crates.io 0.4.2 crate, the 0.4.2 PyPI wheel, the
conda recipe built with rattler-build 0.80.2 and the v0.4.2 tag built with gcc
all pass. The same tag fails with Clang 18.1.3, which is the bug fixed here,
while this branch passes with Clang 18.1.3. Every passing route matched the
reference to within 1.8e-14 in
dist2.