fix: guard webview access after panel disposal - #12
Merged
damoahdominic merged 1 commit intoFeb 18, 2026
Conversation
Both StatusPanel and ConfigPanel could crash with 'Webview is disposed' when _update() or _pollStatus() ran after the panel was closed. Added _disposed flag checked before any webview.html assignment.
damoahdominic
added a commit
that referenced
this pull request
Mar 16, 2026
fix: guard webview access after panel disposal
damoahdominic
added a commit
that referenced
this pull request
Mar 16, 2026
fix: guard webview access after panel disposal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
StatusPanelandConfigPanelcrash with "Webview is disposed" when_update()or_pollStatus()run after the panel has been closed. The async status fetch completes and tries to write HTML to a dead webview.Fix
Added a
_disposedflag to both panels, set ondispose(), checked before everywebview.htmlassignment.Files changed
apps/extension/src/panels/status.ts— guard in_update()and_pollStatus()apps/extension/src/panels/setup.ts— guard in_update()