Repository navigation
Restore adaptive custom scrollbar colors - #71
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Use Neo Notational V Scrollbars enabled, the custom scrollbars kept fixed image colors when the note body palette changed. The notes list also left a system-colored rectangle above its scrollbar, beside the column headers.
Make scrollbar gutters match each browser's body background, with contrasting tracks and thumbs that update when colors change. Keep AppKit's overlay fading and hit testing. Give the empty header corner the same background and hide it with the column headers. This extends the adaptive list colors restored in #68.
Validation on macOS 13.7.8 with Xcode 15.2 (15C500b), using the unsigned Intel Development app under Rosetta:
The full native-controls suite still fails
selected title glyphs contrast with the native selection in both layouts: it counts 7 matching pixels and requires more than 10. A standalone retry and an isolated comparison that restored the original nil header corner produced the same failure. This assertion remains unresolved; the full suite is not green. All disposable test apps were closed.The screenshots deliberately oppose the body palette and window appearance to show that the scrollbar colors follow the body. Captures use disposable notes and have no pixel edits.