Skip to content

Restore adaptive custom scrollbar colors - #71

Merged
dangduc merged 1 commit into
masterfrom
codex/restore-adaptive-scrollbars
Sep 24, 2026
Merged

dangduc merged 1 commit into
masterfrom
codex/restore-adaptive-scrollbars

Conversation

@dangduc

@dangduc dangduc commented Sep 24, 2026

Copy link
Copy Markdown
Owner

With Use Neo Notational V Scrollbars enabled, the custom scrollbars kept fixed image colors when the note body palette changed. The notes list also left a system-colored rectangle above its scrollbar, beside the column headers.

Make scrollbar gutters match each browser's body background, with contrasting tracks and thumbs that update when colors change. Keep AppKit's overlay fading and hit testing. Give the empty header corner the same background and hide it with the column headers. This extends the adaptive list colors restored in #68.

Validation on macOS 13.7.8 with Xcode 15.2 (15C500b), using the unsigned Intel Development app under Rosetta:

  • Development build passed.
  • Focused scrollbar probe passed 165 checks, covering displayed pixels, both body palettes and list layouts, two browser windows, live color changes, overlay scrollbars, and the Settings toggle. The preceding build failed the new header-corner pixel assertion.
  • Multiwindow tests passed 35 checks plus 19 relaunch checks.
  • 50 of 51 regression suites passed across the aggregate run and resumed suites. Wrapped-separator reattachment failed once and passed all 32 checks unchanged on retry. Focus-sensitive suites used Launch Services with unchanged assertions.

The full native-controls suite still fails selected title glyphs contrast with the native selection in both layouts: it counts 7 matching pixels and requires more than 10. A standalone retry and an isolated comparison that restored the original nil header corner produced the same failure. This assertion remains unresolved; the full suite is not green. All disposable test apps were closed.

The screenshots deliberately oppose the body palette and window appearance to show that the scrollbar colors follow the body. Captures use disposable notes and have no pixel edits.

Layout Dark body in a light window Light body in a dark window
Stacked Dark body, stacked Light body, stacked
Side Dark body, side Light body, side

@dangduc
dangduc merged commit 7a65c98 into master Sep 24, 2026
1 check passed
@dangduc
dangduc deleted the codex/restore-adaptive-scrollbars branch October 3, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant