Repository navigation
Preserve fuzzy result excerpts while editing notes - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a note during fuzzy search could reset its result excerpt to the beginning of the note or line, dropping its ellipsis and highlights before fresh match positions arrived. Keep the displayed line and its offsets together until the replacement positions are ready, then update both at once.
The cache retains only line text and offsets. Invalidated results still cannot drive note actions. Regression tests cover pending redraws, updated highlight offsets, and both list layouts.
Validation
Tested on macOS 13.7.8 with Xcode 15.2, using the Intel Development app under Rosetta.
7553c37: both builds report 7 matching glyph pixels where the test requires more than 10.Screenshots
Synthetic note after a body edit, with replacement list-position completion held. The list retains its previous excerpt, ellipsis, and highlights while the new positions are pending.
Stacked layout:
Side layout: