fix: activities一覧で不正な日付 2009-11-31 を 2009-11-30 に修正 - #34
Open
nigyta wants to merge 1 commit into
Open
Conversation
存在しない日付(11月31日)のため、クライアント側ソートで new Date()がInvalid Date→NaNとなりCSS order:0となって、 厳格な日付解釈のブラウザ(Firefox/Safari等)で一覧の先頭に 表示される不具合を修正。 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
_data/achievements.ymlの発表記録 (id: 10-ja) の日付が存在しない日付 2009-11-31（11月は30日まで）になっていたため、2009-11-30 に修正します。不具合の内容
activities 一覧 (
/activities/) のソートはクライアント側 JS (_javascript/taggingListView.js) が<time datetime>をnew Date()でパースし flexbox のorderで並べています。2009-11-31は厳格に日付検証するブラウザ (Firefox / Safari 等) ではInvalid DateとなりgetTime()がNaN、結果element.style.order = NaNが無効値として無視されorder: 0のまま残ります。正常な項目は全て大きな正のorder値になるため、この1件だけが一覧の先頭に表示される不具合が出ていました。修正
_data/achievements.yml:date: 2009-11-31→2009-11-30、day: 31→302009-11-30のため、これに合わせました。確認
🤖 Generated with Claude Code