Skip to content

TUI: decide whether quit keys should quit while the ? key list is open #6

Closed

Description

@devloop01

Current behaviour

With the ? key list open, every key only closes it, including q, ctrl+c and ctrl+d (screen.key in tui.go). Leaving sweep from there takes two presses.

This is deliberate: the box says "Press any key to close", and TestScreenHelpAndReveal asserts "q should only close the key list".

Why it came up

A code review flagged it as inconsistent:

  • The key list itself shows q esc quit.
  • The confirm dialog does let quit through (s.ask != nil && k != "quit").
  • ctrl+c not quitting on the first press is surprising in a terminal app.

Options

  1. Leave it as is.
  2. Let ctrl+c / ctrl+d quit from the key list, and keep q as "close". This needs the key names split, since all three map to "quit" today.
  3. Let every quit key quit from the key list, and update the test.

Left out of #3 because it is a design choice, not a bug.

Activity

  1. added a commit that references this issue on Nov 13, 2026
    5abe807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions