Artkal palettes#2
Open
davidnilssonart wants to merge 2 commits into
Open
Conversation
Added palettes for four of Artkals lines of beads that loads when Perler is started.
dolkow
requested changes
Dec 7, 2016
dolkow
left a comment
Owner
There was a problem hiding this comment.
I know this is your first git commit ever, so I'm going to give you a learning opportunity! There is a small change I'd like you to make before accepting this commit.
|
|
||
| XMLParser xmlp = XMLParser.getInstance(); | ||
| for (String s : new String[]{"hama-builtin.xml", "nabbi-builtin.xml", "perlerbeads-builtin.xml"}) { //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ | ||
| for (String s : new String[]{"hama-builtin.xml", "nabbi-builtin.xml", "perlerbeads-builtin.xml", "artkal-serie-s-5mm-hard.xml", "artkal-serie-r-5mm-soft.xml", "artkal-serie-c-2.6mm-hard.xml", "artkal-serie-a-2.6mm-soft.xml"}) { //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ |
Owner
There was a problem hiding this comment.
Please add corresponding NON-NLS comments for the constant strings (otherwise, Eclipse will nag me about them).
Should look like the rest, just with higher numbers. :)
Added NON-NLS. Also, the added Artkal palettes are only for solid colors, not neon, translucent and others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added palettes for four of Artkals lines of beads that loads when Perler
is started.