Fix calculation of number of elements in tensor for Size([]) tensors - #1
Open
dvmazur wants to merge 1 commit into
Open
Fix calculation of number of elements in tensor for Size([]) tensors#1dvmazur wants to merge 1 commit into
dvmazur wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Dominik!
Thanks for your work on the library!
I was playing around with
pydantic-tensorand found and edge case related to the calculation of the number of elements in a tensor. In PyTorch it is possible to have a []-shaped tensor (torch.tensor(0)), not to be confused with a [0]-shaped one (torch.tensor([]))! The latter case is handled correctly, but the former triggers a ValueError when reduce is applied over the empty iterator.The fix is quite simple as you can see.