Skip to content

chore: add ability to build MCP Bundles (MCPB). see https://github.co…#64

Open
sascha-wedekind wants to merge 4 commits into
dominik1001:mainfrom
sascha-wedekind:main
Open

chore: add ability to build MCP Bundles (MCPB). see https://github.co…#64
sascha-wedekind wants to merge 4 commits into
dominik1001:mainfrom
sascha-wedekind:main

Conversation

@sascha-wedekind

Copy link
Copy Markdown

…m/modelcontextprotocol/mcpb

@dominik1001 dominik1001 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding MCPB support! A few things to address before merging:

Hardcoded version in manifest

mcpb-manifest.json hardcodes "version": "0.8.0" which will drift from package.json immediately. This should either be injected automatically by the pack script (e.g., read from package.json at build time) or removed if the tooling doesn't require it.

.mcpb-stage and *.mcpb not gitignored

If the pack script fails midway, the staging directory will be left behind and could accidentally get committed. Please add .mcpb-stage and *.mcpb to .gitignore.

pack:mcpb script is fragile

The inline shell pipeline is long and hard to maintain. Consider moving it to scripts/pack-mcpb.sh. The leading rm -rf .mcpb-stage also silently deletes anything at that path.

Tool descriptions may drift

The tools array in the manifest duplicates names and descriptions already defined in source code — these could get stale over time. Worth adding a validation step or generating this section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants