Fix record edit when start timestamp changes#252
Open
Cashie1597 wants to merge 1 commit into
Open
Conversation
After a manual edit, rename the on-disk record (and backup) file to match the updated start time in the JSON. Record keys shown in the CLI are derived from record.Start, so a stale filename caused "record not found" on re-edit. Fixes dominikbraun#246
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #246
After a manual
timetrace edit record, rename the on-disk record file (and its.bakbackup, if present) to match the updatedstarttimestamp in the JSON.Record keys shown in
timetrace list recordsare derived fromrecord.Start, not the filename. When those diverged, a second edit using the displayed key failed withrecord not found.Includes unit tests for rename and no-op cases.