Fixed early scan termination in query log parsing that skipped recent entries - #17
Merged
Conversation
dominikhei
force-pushed
the
fix-query-log-parsing
branch
from
July 24, 2026 09:16
3532379 to
d75ac20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseLogFile broke out of the scan as soon as it hit an entry older
than the lookback cutoff. Query log files are append-only and thus
sorted oldest-first, so this often broke on the very first line and
silently skipped the rest of the file.
Replaced the break with a continue so old entries are skipped
individually instead of aborting the scan. This drops the early-exit
optimization in favor of correctness
Note: Makes sense to read the log file form the back in a future release