Skip to content

fix(handler): make update_log_meta/1 a no-op outside a request (1.4) - #141

Merged
zmstone merged 1 commit into
emqx:release-1.4from
zmstone:260917-update-log-meta-r14
Sep 18, 2026
Merged

zmstone merged 1 commit into
emqx:release-1.4from
zmstone:260917-update-log-meta-r14

Conversation

@zmstone

@zmstone zmstone commented Sep 17, 2026

Copy link
Copy Markdown
Member

Summary

Backport of #140 to the 1.4 line.

update_log_meta/1 now does nothing and returns ok when the calling process does not handle a minirest request. Before, it raised badmap.

release-1.4 starts at tag 1.4.12. emqx dev-60, dev-61 and dev-62 pin 1.4.12. The 1.5 line bumps cowboy_swagger to 3.0.0, which removes the bundled Swagger UI, so these emqx branches stay on 1.4.x. After this PR merges, tag 1.4.13 on release-1.4.

The cherry-pick drops the cookie tests and the cookie README section from the conflict context. The 1.4 line does not have cookie support.

Tests

  • t_update_log_meta_outside_request: update_log_meta/1 returns ok and writes nothing outside a request.

`update_log_meta/1` now does nothing and returns `ok` when the calling
process does not handle a minirest request. Before, it raised `badmap`.

Backport of 87088e2 (emqx#140) to the 1.4 line.
@zmstone
zmstone marked this pull request as ready for review September 17, 2026 20:50
@zmstone
zmstone merged commit 9c4aa5e into emqx:release-1.4 Sep 18, 2026
2 checks passed
@zmstone
zmstone deleted the 260917-update-log-meta-r14 branch September 18, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants