Fix model ID to 3D model mapping bug - #772
Open
johschmitz wants to merge 1 commit into
Open
Conversation
If model file not explicitly specified set it based on lookup table.
johschmitz
requested review from
eknabevcc,
esmini and
slundel6
as code owners
February 10, 2026 21:43
Collaborator
|
Do you have a scenario example pinpointing the issue? I think you have a good patch, but I'd like to clearly understand what case/gap it fixes. |
Contributor
Author
|
This is for the case when no 3D models are specified in the vehicle catalog xml. In that case it needs to fall back to use different looking models (different colors) for the different entities based on IDs. There was already some code for that but it was not working properly. Basically just remove the 3d model references from the vehicle catalog to test this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If model file not explicitly specified set it based on lookup table.