Fixes #780#781
Open
MatteoRagni wants to merge 3 commits into
Open
Conversation
Checks the validity of lane_link before searching for the connected lane. The logic of the code has been inverted to continue-early in the look if one of the reference is null. This is my first contribution to the project, make sure to review it!
Collaborator
|
Really nice find and fix, revealing solid understanding of OpenDRIVE junction structure. Impressive! I made a slight formatting to the commit, but kept you as author of course. Merged on dev. Pull request will be closed when merged to master by next release. |
Contributor
Author
|
Thanks Emil! |
GT-karny
added a commit
to GT-karny/esmini
that referenced
this pull request
Jun 13, 2026
UpdateOSIIntersection still had the pre-fix pattern lane->GetLink(type)->GetId() with no null check on GetLink(); upstream fixed this in 7a0844b ('Check validity of lane_link preventing segfault', esmini esmini#780/esmini#781) which is present in the in-tree core OSIReporter.cpp but was never ported to the fork (audit CORE-1). Port the three-stage early-continue form verbatim. Other GetLink()->GetId() sites in this file are already guarded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks validity for lane link, continues-early on null ptrs.
Please refer to issue #780 for more information.