Add OpenDRIVE 1.9 temporary lane layer support#815
Conversation
0dc24f4 to
98c1dd3
Compare
|
I ran |
|
I checkout out your PR and ran: These are the files it formatted (the diff per file is too large to paste here): If you don't have pre-commit installed, how to do it is part of the user guide. |
|
Hm, strange, I successfully ran clang-format locally on the last PR. I will check it one more time. Maybe I missed some files due to some reason or maybe a wrong version or so, could you say which version you used @slundel6? 15? |
|
After I ran ./support/script/clang-format-runner.sh runs: Maybe you don't have clang-format-15 installed and it fails silently? Or forgot to run |
6db7138 to
37714ec
Compare
|
I think the conflict is because your branch is based on a slightly outdated dev branch. See if you can rebase your commit on latest dev and then try push again. |
fe9e2a5 to
f6931fa
Compare
|
Finally managed to rebase and pass all the linting stuff. Some tests failing though need to see how to fix it. |
6b93265 to
b9ca967
Compare
|
Managed to pass CI, please start review if time permits. Run example with |
|
Nice! Yes, we will review as soon as we find the time. The feature affects more code than first anticipated. |
No description provided.