Rake class rewrite + improved functionality - #1
Open
pmbaumgartner wants to merge 10 commits into
Open
Conversation
Owner
|
Excellent! I'm a little short on time at the moment, but I'll try to dig into this in the next few days |
Author
|
No worries, I'm not in any rush, just curious to see your feedback. Enjoy your holiday(s)! |
Owner
|
Wow, sorry, time got away from me. Just finished a job switch, and moving this weekend. I promise I haven't forgotten about this, just been a little short on time recently! |
Author
|
No problem, hope you'll be settling down soon. I haven't made any changes since the PR. |
| # continue | ||
|
|
||
| punct_suffix = word[-1] in self.phrase_delimiters | ||
| punct_prefix = word[0] in self.phrase_delimiters |
Owner
There was a problem hiding this comment.
Spacing here looks off, can you run this through flake8 or something?
Owner
|
Yeah, run this through flake8 and get those changes in, but it looks good to me. Have you had any luck updating the tests to use your new structure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rakeclass.collectionslib (Counteranddefaultdict)Rakeclass, no need for them to be exposed outside (though they can still be called if need befoxstopword list by default, since it returns results more similar to the abstract used as an example in the original paper, and thesmartstopword list is overkillRake.run()can now take a tokenized list of words as input for alternative tokenizer useRake.run()now returns a sorted list ofnamedtuple KeywordScores, sorted by overall score and also containingsum_degandsum_freqmetrics. These can also be accessed via theRake.keyword_scoresattribute after a call toRake.run()Rake.word_scoresis a class attribute that returns a sorted list ofnamedtuple WordScores, sorted by overall score and containingdegandfreqmetrics, available after callingRake.run()