Issue #393: add circuit breaker for network failures#416
Open
magiconair wants to merge 3 commits intomasterfrom
Open
Issue #393: add circuit breaker for network failures#416magiconair wants to merge 3 commits intomasterfrom
magiconair wants to merge 3 commits intomasterfrom
Conversation
route del * * http://host:port will delete all routes for that destination
This patch adds a circuit breaker monitor which issues route table fragments to delete routes for which the circuit breaker is open. The current implementation supports only the HTTP path. TCP and WS will follow. The integration test isn't testing the behavior automatically yet but can be used to eyeball the behavior. This needs to be improved. Also missing is the code to GC the circuit breakers that aren't tripped over time but that should be easy to implement in this code. Fixes #393
a55de9d to
04f958c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a circuit breaker monitor which issues route table
fragments to delete routes for which the circuit breaker is open.
The current implementation supports only the HTTP path. TCP and WS will
follow.
The integration test isn't testing the behavior automatically yet
but can be used to eyeball the behavior. This needs to be improved.
Also missing is the code to GC the circuit breakers that aren't
tripped over time but that should be easy to implement in this
code.
Fixes #393