fix: cancel CLI commands on SIGINT/SIGTERM via root context - #97
Merged
Conversation
get, seed, and server already honor cmd.Context() for in-flight HTTP and shutdown, but Execute used plain Execute() with a non-cancelable background context. Install signal.NotifyContext at the process root so Ctrl-C/SIGTERM aborts downloads and lets defers run instead of relying on an uncatchable process kill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
get,seed, andserveralready usecmd.Context()for in-flight HTTP and shutdown, butExecutecalled plainrootCmd.Execute()with a non-cancelable background context.SIGINT/SIGTERM therefore only stopped the process via the default fatal signal path. In-flight downloads were not canceled through context, and command defers (temp cleanup, etc.) did not get a normal return path.
Change
signal.NotifyContextfor SIGINT/SIGTERM at the process rootExecuteContextso cancel reaches every subcommandexecute's context (including already-canceled)serverstill installs its own nestedNotifyContextfor gracefulShutdown; that remains valid when the parent context is also signal-aware.Verify