Bug 1530596 - Fix the "Missing reviewers" warning r=glob

Reviewers: glob

Reviewed By: glob

Bug #: 1530596

Differential Revision: https://phabricator.services.mozilla.com/D21351

Bug 1527765 - Fix patching UTF-8 files. r=glob

Summary:

A `UnicodeEncodeError` was raised on patching files. This patch encodes
the content before writing it to a temporary patch file.

Reviewers: glob

Reviewed By: glob

Bug #: 1527765

Differential Revision: https://phabricator.services.mozilla.com/D19920

Bug 1527288 - Recognize the cinnabar extension

Reviewers: glob

Reviewed By: glob

Bug #: 1527288

Differential Revision: https://phabricator.services.mozilla.com/D19484

Bug 1503903 - Patch revisions r=glob

Summary:

- `--apply-to TARGET` Depending on the `TARGET` the starting commit:
  - `base` (default) find the base commit in the oldes ancestor revision,
  - `here` use current commit,
  - `NODE` a commit identified by SHA1 or (in Mecurial) revision number

- `--raw` Print out the diffs of each revision starting from the oldest
ancestor. It can be used to patch the working directory with an external tool:
`$ moz-phab patch D123 --nocommit | patch -p1`.

- `--no-commit` Use the system's `patch` command to patch the diffs. No commit
or branch is created.

- `--no-bookmark` Prevent creating the bookmark on Mercurial repos.

moved self.branch to the new `before_submit` function to allow the
`patch` to work from the detached HEAD state.

Reviewers: glob

Reviewed By: glob

Bug #: 1503903

Differential Revision: https://phabricator.services.mozilla.com/D15914

Bug 1522391 - Prevent arc from waiting on user input, which manifests…

… as a moz-phab hang r=glob

Summary:
Connecting the STDIN to the PIPE will make arc throw an exception on reading
user input:
```(PhutilConsoleStdinNotInteractiveException) The program is attempting to
read user input, but stdin is being piped from some other source (not a TTY)```

Reviewers: glob

Reviewed By: glob

Bug #: 1522391

Differential Revision: https://phabricator.services.mozilla.com/D17605

Bug 1522748 - fix broken help. r?zalun

Summary:

fixes `moz-phab submit --help` throwing TypeError.

also fixes:
- `TemporaryFileName` --> `temporary_file`: this is a function not a
   class
- `def git_out(self, command, path=None, env={}, **kwargs):`
  `env={}` is a mutable default param, which is a gotcha
- `_find_forks_to_rebase` should be static

Reviewers: zalun

Reviewed By: zalun

Bug #: 1522748

Differential Revision: https://phabricator.services.mozilla.com/D17596

Bug 1519540 - Amend commits using the right author info and date r=glob

Summary:
To amend a commit `mozphab` in a Git repository is using a `git commit-tree`
command. It is creating a new commit which is later rebased.
This patch provides the right author information to the `git commit-tree`.

Reviewers: glob

Reviewed By: glob

Bug #: 1519540

Differential Revision: https://phabricator.services.mozilla.com/D17235

Improve handling of temporary files for cross-platform compatibility

Summary:
This patch adds a TemporaryFileName() context manager that takes
a string and writes that string to a temporary file.
The temporary file will exist for the duration of the context
and can be passed to other programs for reading.

This change is needed because (without C-level API calls that are not exposed to
python) it is not possible for multiple processes to both have an open handle on
a file at the same time.

This change also removes the open() and seek() behavior used for calling arc,
instead of using a temporary file and a call to open(). This was done to make
the code simpler, allowing for the simpler API of TemporaryFileName().

Test Plan: I'll ask zalun how to run through a full text with both VCSes on Windows.

Reviewers: zalun

Reviewed By: zalun

Bug #: 1514906

Differential Revision: https://phabricator.services.mozilla.com/D14872

Bug 1510279 - (HG) Do not rebase if parent is not changed. r=glob,dylan

Summary:
If no change has been done in the parent (part of the stack
resubmitted) there is no need for rebase commit on the new parent.
Mercurial would raise an exception and stop moz-phab execution.
This patch reads the real parent and omits the rebase step if it's
the same as the parent in the commit stack.

Reviewers: glob, dylan

Reviewed By: dylan

Bug #: 1510279

Differential Revision: https://phabricator.services.mozilla.com/D14544

Bug 1512329 - Add group reviewer aliases to the check. r=glob

Reviewers: glob

Reviewed By: glob

Bug #: 1512329

Differential Revision: https://phabricator.services.mozilla.com/D13924