struct: stop trying to map empty nil pointers, correctly map most slice pointers#372
Open
DeadLockStarve wants to merge 2 commits intogo-ini:mainfrom
Open
struct: stop trying to map empty nil pointers, correctly map most slice pointers#372DeadLockStarve wants to merge 2 commits intogo-ini:mainfrom
DeadLockStarve wants to merge 2 commits intogo-ini:mainfrom
Conversation
This was referenced Nov 1, 2025
Open
2a15358 to
3374c1a
Compare
3374c1a to
65fefbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Changes management of nil pointers thus solves #369 and #370. #371 unsolved because of structural issues: looking at the code we can see there that the current approach is calling a different for loop depending on the type. There seems to be a clear reason: increasing performance by reducing function calls and reflection.
However this comes at the cost of maintainability, while in this library we have duplicated normalization for slices and for single types, in other libraries like BurntSushi/toml normalization is done in a single function called for each element by the slice management loop.
What's preferred by the codebase in this case, performance or mantainability?
Checklist