key: apply ValueMapper to substituted reference values#382
Merged
Conversation
When a key's value contains a %(...)s reference, the substituted text
was inserted verbatim from the referenced key's raw value, bypassing
ValueMapper. As a result, placeholders like ${ENV_VAR} embedded in a
referenced key were never expanded.
Substitute via nk.String() so the referenced key goes through its own
transformValue (ValueMapper + further reference expansion) before being
inlined.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Replace deprecated io/ioutil with io and os equivalents. - Replace deprecated reflect.Ptr alias with reflect.Pointer. - Use fmt.Fprint(&buf, ...) instead of buf.WriteString(fmt.Sprint(...)). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%(...)sreference, the substituted text was inserted verbatim from the referenced key's raw value, bypassingValueMapper. Placeholders like${ENV_VAR}embedded in a referenced key were never expanded.nk.String()so the referenced key goes through its owntransformValue(ValueMapper + further reference expansion) before being inlined.t.Cleanupto a pre-existing test that leakedValueMapperstate into sibling subtests (latent issue surfaced by the fix).Test plan
TestRecursiveValuessubtest:${...}placeholder inside a referenced key gets mapped after substitution.go test ./...passes.🤖 Generated with Claude Code