Make FindDynamicLibrariesTask respond to the changes in directories configured as searchPaths - #215
Draft
paxbun wants to merge 4 commits into
Draft
Make FindDynamicLibrariesTask respond to the changes in directories configured as searchPaths#215paxbun wants to merge 4 commits into
FindDynamicLibrariesTask respond to the changes in directories configured as searchPaths#215paxbun wants to merge 4 commits into
Conversation
paxbun
marked this pull request as draft
September 14, 2025 06:11
Member
Author
|
This is blocked by #216. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
FindDynamicLibraryTask.searchPathsfrom@Inputto@InputFiles.FindDynamicLibraryTask.Testing
Made
:tests:gradle:jvm-onlybuild multiple C++ libraries.Tested manually with the procedure as follows:
"gobley-fixture-gradle-jvm-only-cpp-2",part inbuild.rsso Gradle fails to find the second library.CppLibraryTest2fails."gobley-fixture-gradle-jvm-only-cpp-2",part and run the test again.FindDynamicLibraryTaskuses the cached build result, resulting in a test failure. With this change,FindDynamicLibraryTaskresponds to the changes and successfully finds the new library.Issues Fixed
Fixes: #214