Remove dangling consumerProguardFiles references from examples - #292
Draft
SalvatoreT wants to merge 1 commit into
Draft
Remove dangling consumerProguardFiles references from examples#292SalvatoreT wants to merge 1 commit into
SalvatoreT wants to merge 1 commit into
Conversation
## Changes
`examples/custom-types`, `examples/todolist` and `examples/arithmetic-procmacro`
still declare `consumerProguardFiles("proguard-rules.pro")` in `defaultConfig`,
but #140 deleted those `proguard-rules.pro` files when the UniFFI plugin took
over generating the rules. The declarations have pointed at missing files ever
since.
## Testing
`:examples:todolist:assembleRelease` succeeds, and the resulting AAR's
`proguard.txt` still carries the rules generated by the UniFFI plugin, so the
removed line was contributing nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
examples/custom-types,examples/todolistandexamples/arithmetic-procmacrostill declareconsumerProguardFiles("proguard-rules.pro")indefaultConfig, but #140 deleted thoseproguard-rules.profiles when the UniFFI plugin took over generating the rules. The declarations have pointed at missing files ever since.Testing
:examples:todolist:assembleReleasesucceeds, and the resulting AAR'sproguard.txtstill carries the rules generated by the UniFFI plugin, so the removed line was contributing nothing.Notes
Branched off
main, independent of #291. Noticed while investigating that one, but unrelated to it.Drafted with Claude Code and reviewed by me before opening.