fix(net/ghttp): windows web admin restart only shutdowns but doesn't restart#4809
Open
lonevle wants to merge 1 commit into
Open
fix(net/ghttp): windows web admin restart only shutdowns but doesn't restart#4809lonevle wants to merge 1 commit into
lonevle wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Windows web admin restart only shutdowns but doesn't restart
Problem
On Windows, accessing
/debug/admin/restartonly shuts down the server but does not restart it. The process exits after printingall servers shutdown, and no new process is started.Root Cause
In the Windows branch of
restartWebServers,forceCloseWebServers(ctx)is called beforeforkRestartProcess:Closing the servers triggers
closeChan→Run()returns →main()returns → process exits. SoforkRestartProcessnever gets a chance to execute.Fix
Remove
forceCloseWebServers(ctx). The new process already kills its parent inserverProcessInit()before binding the port (this is the original design intent, see the comment inghttp_server.go):Notes
signal == nil) is fixed.signal != nilbranch is untouched (Windows does not register restart signals).