Fix unnecessary parse and typecheck overhead when using IR conversion check - #4521
Open
magancarz wants to merge 1 commit into
Open
Fix unnecessary parse and typecheck overhead when using IR conversion check#4521magancarz wants to merge 1 commit into
magancarz wants to merge 1 commit into
Conversation
Contributor
Author
|
@richmckeever I've answered your question about used compilation mode by updating the description with used command. |
dplassgit
reviewed
Jul 27, 2026
| dslx_paths, ir_convert_options, elem, | ||
| module_name, &printed_error); | ||
| absl::StatusOr<std::string> ir_conv_result = | ||
| ConvertOneFunction(tm.module, elem, &import_data, |
Contributor
There was a problem hiding this comment.
Is this change the whole reason it's faster? I'm having trouble wrapping my head around the immense increase in speed with this change.
Contributor
Author
There was a problem hiding this comment.
It speeds up the IR conversion check, because ConvertOneFunction gives a possibility to do module typechecking just once by performing it earlier and passing it with tm.module, while ConvertFilesToPackage call did module typechecking separately for each IR conversion check entry in ir_converter.cc#L641.
dplassgit
approved these changes
Jul 27, 2026
dplassgit
left a comment
Contributor
There was a problem hiding this comment.
@richmckeever do you have any thoughts? It looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes unnecessary overhead introduced by duplicate parsing and typechecking when IR conversion check is enabled. As tested with
bazel run -c opt //xls/modules/zstd:zstd_dec_dslx_testand commented tests for simplicity of measuring IR conversion check overhead - onmainbranch it takes ~3.5 min to finish executing the target, while with this PR changes it finishes in ~38 seconds. Without IR conversion check, the execution time is ~27 seconds. As a result it narrows down IR conversion check overhead from ~3 min to ~11 seconds in the tested case.