Repository navigation
xls/dslx/ir_convert: Propagate SourceInfo to converted function Param nodes - #5416
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_1021685608
branch
4 times, most recently
from
November 18, 2026 14:12
9ab7e08 to
b97ca13
Compare
… nodes Pass the parameter's `SourceInfo` (`loc`) to `FunctionBuilder::Param` in `FunctionConverter::HandleParam` and `EmitImplicitTokenEntryWrapper` so that IR `Param` nodes (and downstream input ports and pipeline input registers in codegen) retain their DSLX source locations. Refs #5413 PiperOrigin-RevId: 1024657936
copybara-service
Bot
force-pushed
the
test_1021685608
branch
from
November 18, 2026 15:47
b97ca13 to
c8dd021
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xls/dslx/ir_convert: Propagate SourceInfo to converted function Param nodes
Pass the parameter's
SourceInfo(loc) toFunctionBuilder::ParaminFunctionConverter::HandleParamandEmitImplicitTokenEntryWrapperso that IRParamnodes (and downstream input ports and pipeline input registers in codegen) retain their DSLX source locations.Refs #5413