Skip to content

Fix xls_cc_embed_data header and #embed paths for external consumers. - #5435

Merged
copybara-service[bot] merged 1 commit into
mainfrom
test_1023140012
Nov 17, 2026
Merged

copybara-service[bot] merged 1 commit into
mainfrom
test_1023140012

Conversation

@copybara-service

Copy link
Copy Markdown

Fix xls_cc_embed_data header and #embed paths for external consumers.

  1. Pass -header_include_path computed via repo_relative_path() so the
    generated .cc includes the generated .h without external/<repo>/
    or execroot prefixes.
  2. Compute #embed relative to the generated .cc file directory so
    Clang finds embedded inputs without relying on -iquote of the
    execroot when XLS is consumed as an external Bzlmod module.

@copybara-service
copybara-service Bot force-pushed the test_1023140012 branch 2 times, most recently from 1878934 to 742fbf1 Compare November 17, 2026 07:54
…ers.

1. Pass `-header_include_path` computed via `repo_relative_path()` so the
   generated `.cc` includes the generated `.h` without `external/<repo>/`
   or execroot prefixes.
2. Compute `#embed` relative to the generated `.cc` file directory so
   Clang finds embedded inputs without relying on `-iquote` of the
   execroot when XLS is consumed as an external Bzlmod module.

PiperOrigin-RevId: 1023474917
@copybara-service
copybara-service Bot merged commit 18d1104 into main Nov 17, 2026
5 checks passed
@copybara-service
copybara-service Bot deleted the test_1023140012 branch November 17, 2026 08:25

This branch was previously deployed

1 inactive deployment
github-pages — 18d1104f Deployed Nov 17, 2026 by copybara-service[bot] via deploy #14508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant