feat: Support OIDC custom property claims for Actions#4411
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4411 +/- ##
=======================================
Coverage 97.52% 97.53%
=======================================
Files 193 193
Lines 19668 19709 +41
=======================================
+ Hits 19182 19223 +41
Misses 268 268
Partials 218 218 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| // GitHub API docs: https://docs.github.com/rest/actions/oidc?apiVersion=2022-11-28#create-an-oidc-custom-property-inclusion-for-an-enterprise | ||
| // | ||
| //meta:operation POST /enterprises/{enterprise}/actions/oidc/customization/properties/repo | ||
| func (s *ActionsService) SetEnterpriseOIDCCustomPropertyClaim(ctx context.Context, enterprise string, body OIDCCustomPropertyClaim) (*OIDCCustomPropertyClaim, *Response, error) { |
There was a problem hiding this comment.
We can't use OIDCCustomPropertyClaim here. Because this endpoint only accepts custom_property_name in body parameter. so let's introduce a new request struct for this.
There was a problem hiding this comment.
ah right. just added a new type OIDCCustomPropertyClaimResponse and updated the List/GET methods to use that instead.
| // GitHub API docs: https://docs.github.com/rest/actions/oidc?apiVersion=2022-11-28#create-an-oidc-custom-property-inclusion-for-an-organization | ||
| // | ||
| //meta:operation POST /orgs/{org}/actions/oidc/customization/properties/repo | ||
| func (s *ActionsService) SetOrgOIDCCustomPropertyClaim(ctx context.Context, org string, body OIDCCustomPropertyClaim) (*OIDCCustomPropertyClaim, *Response, error) { |
There was a problem hiding this comment.
same here.
Let's introduce a new request struct for this.
There was a problem hiding this comment.
I ended up making OIDCCustomPropertyClaimResponse and updating the List/GET methods to use that but I can instead switch it back & create the Request one if you prefer.
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Adds
GET,POST,DELETEmethods for enterprises and organizations OIDC custom property claims for GitHub Actions./enterprises/{enterprise}/actions/oidc/customization/properties/repo/orgs/{org}/actions/oidc/customization/properties/repoAPI Docs: https://docs.github.com/en/rest/actions/oidc?apiVersion=2026-03-10
closes #4407