Explicitly set MSL version for Metal shader compilation - #774
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_964271450
branch
2 times, most recently
from
August 15, 2026 00:15
c675758 to
b03e3fa
Compare
Restrict that to iOS, we don't actually build this for Mac, and it's not until later versions that there's a single MSL standard version for Mac and iOS. (The iOS simulators are still under `@platforms//os:ios`.) PiperOrigin-RevId: 964977408
copybara-service
Bot
force-pushed
the
test_964271450
branch
from
August 15, 2026 00:34
b03e3fa to
ab2bfdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly set MSL version for Metal shader compilation
Restrict that to iOS, we don't actually build this for Mac, and it's not until later versions that there's a single MSL standard version for Mac and iOS. (The iOS simulators are still under
@platforms//os:ios.)