unotify: write reports privately and atomically - #293
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Write seccomp-unotify reports through a mode-0600 temporary file in the destination directory, then atomically replace the configured report path.
Why
Seccomp-unotify reports can contain traced
execvearguments and environment entries. The current directO_CREAT | O_TRUNCwrite creates a new report as mode 0644 under a typical umask and follows a pre-existing symlink. With a predictable report path in a shared directory, another local user can therefore read report contents or redirect a privileged report write into another file.Creating the report privately and replacing the destination atomically keeps new contents owner-only and replaces a destination symlink rather than following it.
Validation