Harden jail mounts, capabilities, and nstun networking defaults - #296
Open
M0nd0R wants to merge 1 commit into
Open
Harden jail mounts, capabilities, and nstun networking defaults#296M0nd0R wants to merge 1 commit into
M0nd0R wants to merge 1 commit into
Conversation
Block mount-destination path escape before pivot_root, fail closed on isolation flag/capability drops, expand nstun SSRF denylists, and make unmatched traffic rules default-deny so empty user_net is not wide open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
../ path escape beforepivot_root) and fail closed when mount isolation flags cannot be applied.CAP_SETPCAP) and treatPR_SET_NO_NEW_PRIVSfailure as fatal unless explicitly disabled.ALLOWrules).Test plan
make/ Docker image)dstcontaining..is rejected and does not create host paths outside the staging rootuser_netwithbackend: NSTUNdrops unmatched egress; configs with explicitALLOWstill pass traffic169.254.169.254/ multicast are dropped by the SSRF gateuser_net(e.g.tests/nstun.cfg)