net: seal inherited fds before executing pasta - #297
Open
soul-sol wants to merge 1 commit into
Open
Conversation
Signed-off-by: solim <7576268+soul-sol@users.noreply.github.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/proc/self/fdwhenclose_range(CLOSE_RANGE_CLOEXEC)is unavailablepastahelperSecurity rationale
pastaProcess()previously ignored the result ofutil::makeRangeCOE(). On kernels withoutclose_range(), or when an outer seccomp policy denies it, non-CLOEXECdescriptors inheritedby nsjail could survive into the external
pastahelper. Those descriptors can expose files,directories, sockets, or other parent-process capabilities outside the intended jail boundary.
This is separate from #275: that change constrains how the helper executable and environment are
selected, while this change prevents unrelated parent descriptors from crossing the helper
execve.Validation
returning
ENOSYSforclose_range; a test helper read the sentinel before this patchclose_range()path also executes the helper without fd 123/procwhile denyingclose_range()and confirmed nsjail fails closed withoutexecuting the helper
make clean && make -j2/bin/trueand/bin/falsejail smoke testsgit diff --check