Skip to content

unix: add hwtstamp tx_types and rx_filters from kernel - #283

Open
cappe987 wants to merge 1 commit into
golang:masterfrom
cappe987:additional-tstamp-flags
Open

unix: add hwtstamp tx_types and rx_filters from kernel#283
cappe987 wants to merge 1 commit into
golang:masterfrom
cappe987:additional-tstamp-flags

Conversation

@cappe987

Copy link
Copy Markdown

These types and filters has existed in the Linux kernel for a long time.
Now the complete lists are added to Go as well.

No issue exists and I deemed this change trivial enough to not require one.

Reference in Linux kernel:
https://github.com/torvalds/linux/blob/master/include/uapi/linux/net_tstamp.h#L112 https://github.com/torvalds/linux/blob/master/include/uapi/linux/net_tstamp.h#L150

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: bff7dcc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/805700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

These types and filters has existed in the Linux kernel for a long time.
Now the complete lists are added to Go as well.

Reference in Linux kernel:
https://github.com/torvalds/linux/blob/master/include/uapi/linux/net_tstamp.h#L112
https://github.com/torvalds/linux/blob/master/include/uapi/linux/net_tstamp.h#L150
@cappe987
cappe987 force-pushed the additional-tstamp-flags branch from bff7dcc to ae9f762 Compare July 25, 2026 08:58
@cappe987 cappe987 changed the title unix: Add hwtstamp tx_types and rx_filters from kernel unix: add hwtstamp tx_types and rx_filters from kernel Jul 25, 2026
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: ae9f762) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/805700.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Casper Andersson:

Patch Set 2:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/805700.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants