Skip to content

build(deps): drop russh's default rsa feature - #1051

Merged
norrietaylor merged 1 commit into
mainfrom
chore/drop-russh-rsa-feature
Jul 29, 2026
Merged

build(deps): drop russh's default rsa feature#1051
norrietaylor merged 1 commit into
mainfrom
chore/drop-russh-rsa-feature

Conversation

@norrietaylor

@norrietaylor norrietaylor commented Jul 29, 2026 •
edited by macroscopeapp Bot
Loading

Copy link
Copy Markdown
Member

Turns off russh's default rsa feature, since this workspace only ever generates and parses Ed25519 SSH keys.

Note

Drop russh's default RSA feature and use aws-lc-rs instead

  • Updates the russh dependency in Cargo.toml to disable default features and explicitly enable aws-lc-rs and flate2.
  • Removes the RUSTSEC-2023-0071 advisory ignore from deny.toml, as the RSA feature causing that advisory is no longer included.

Macroscope summarized 03826eb.

@norrietaylor @claude
build(deps): drop russh's default rsa feature
03826eb 
Every SSH host key this workspace generates is Ed25519, and the daemon
authenticates peers with `auth_none` gated on transport locality, so no
code path parses or verifies an RSA key. Turning off russh's default
`rsa` feature drops the `rsa` and `pkcs1` crates from the tree.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 284ba849-16a3-4d26-a24b-86b0579c6602

📥 Commits

Reviewing files that changed from the base of the PR and between c1d466c and 03826eb.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • deny.toml

Comment @coderabbitai help to get the list of available commands.

@norrietaylor
norrietaylor merged commit 21470a4 into main Jul 29, 2026
29 checks passed
@norrietaylor
norrietaylor deleted the chore/drop-russh-rsa-feature branch July 29, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twitchyliquid64 twitchyliquid64 twitchyliquid64 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@norrietaylor @twitchyliquid64