Skip to content

fix: exclude switch crate filesystem tests from Miri isolation #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norrietaylor merged 1 commit into from
Jul 29, 2026
Merged

fix: exclude switch crate filesystem tests from Miri isolation #1079

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/switch/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,10 @@ mod tests {
assert!(DEFAULT_GVPROXY_BIN.ends_with(GVPROXY_FILE));
}

// The resolver tests below create real temp dirs; Miri's default isolation
// has no `mkdir`, so exclude them there. The miri lane still covers the pure
// subnet/MAC/vsock primitives above, which is what it was added to check.
#[cfg_attr(miri, ignore)]
#[test]
fn installed_gvproxy_prefers_existing_user_local_install() {
let _g = ENV_LOCK.lock().unwrap();
Expand All @@ -376,6 +380,7 @@ mod tests {
unsafe { std::env::remove_var("MINIMAL_BIN") };
}

#[cfg_attr(miri, ignore)]
#[test]
fn ignores_an_upstream_named_binary_in_the_bin_dir() {
// A foreign `gvproxy` (podman's, crc's) sitting in the bin dir must not
Expand All @@ -396,6 +401,7 @@ mod tests {
// flip on a host that has either binary installed — failing on precisely
// the pre-rename hosts the legacy branch exists to serve.

#[cfg_attr(miri, ignore)]
#[test]
fn falls_back_to_the_current_system_path() {
let tmp = tempfile::tempdir().unwrap();
Expand All @@ -407,6 +413,7 @@ mod tests {
assert_eq!(resolve_installed(None, &system, &legacy), system);
}

#[cfg_attr(miri, ignore)]
#[test]
fn falls_back_to_the_legacy_system_path_when_only_it_exists() {
let tmp = tempfile::tempdir().unwrap();
Expand All @@ -417,6 +424,7 @@ mod tests {
assert_eq!(resolve_installed(None, &system, &legacy), legacy);
}

#[cfg_attr(miri, ignore)]
#[test]
fn reports_the_current_system_path_when_neither_exists() {
let tmp = tempfile::tempdir().unwrap();
Expand All @@ -427,6 +435,7 @@ mod tests {
assert_eq!(resolve_installed(None, &system, &legacy), system);
}

#[cfg_attr(miri, ignore)]
#[test]
fn user_local_install_beats_both_system_paths() {
let tmp = tempfile::tempdir().unwrap();
Expand Down