Skip to content

feat(min): min with no args prints the help text - #1089

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/min-means-min-help
Jul 29, 2026
Merged

feat(min): min with no args prints the help text#1089
twitchyliquid64 merged 1 commit into
mainfrom
tom/min-means-min-help

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Change bare min with no subcommand to print help and exit

Previously, running min with no arguments would attempt to resolve and attach to a session (or activate a new one). It now prints the top-level CLI help and exits successfully without starting the daemon or creating sessions.

  • cmd_default in lib.rs is replaced with a synchronous function that calls clap::CommandFactory to print help.
  • The ensure_activate_on_empty_allowed guard and related session-resolution logic are removed from the default path.
  • Users should use min session attach or min session activate for the previous behavior.
  • Behavioral Change: bare min no longer starts the daemon or attaches to a session; existing scripts relying on that behavior will need to be updated.

Macroscope summarized 25aa096.

Summary by CodeRabbit

  • Behavior Changes

    • Running min without a subcommand now displays top-level help and exits successfully.
    • Bare min no longer contacts the daemon, activates sessions, or attaches to existing sessions.
    • Use explicit session commands to activate or attach to a session.
  • Documentation

    • Updated CLI reference documentation to reflect the new default behavior and command guidance.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Bare min now prints top-level help and exits successfully without contacting the daemon or creating sessions. The CLI implementation, related comments, tests, and reference documentation were updated to reflect this behavior.

Changes

Bare min behavior

Layer / File(s) Summary
Default help flow
crates/minimal/src/lib.rs, docs/reference/cli-min.md, docs/reference/cli.md
The no-subcommand dispatch now prints top-level help synchronously, obsolete activation gating and its refusal test were removed, and documentation describes min session attach and min session activate for session actions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: norrietaylor

Poem

I’m a rabbit with help on my mind,
Bare min leaves sessions behind.
No daemon to wake,
No session to make,
Just guidance, neatly aligned.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The Summary is clear, but the template's Testing and Checklist sections are missing, so the description is incomplete. Add a Testing section with commands/output and fill the Checklist, including docs updated and whether BREAKING CHANGE is needed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is a conventional commit that accurately states the main change: bare min now prints help and exits.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 merged commit 3e2da4b into main Jul 29, 2026
29 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/min-means-min-help branch July 29, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants