fix: gate the min dirs Mesh enrolment row behind the remote-access feature - #1150
Conversation
min dirs printed a Mesh enrolment row in every build, but the mesh subcommands compile only under the remote-access feature, which is off by default, so min mesh is an unrecognized subcommand there. The same row also silently moved from the Config group to State under --minimal-dir with no hint it had relocated. Gate the row, its group selection, and the mesh-enrolment path lookup behind remote-access so it appears only when the commands it points at exist. A gated row can no longer surprise anyone by moving groups.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Comment |
Reviewed — correct, and I verified the path CI cannot reachThe gating is symmetric and complete: the import, both The part worth flagging: I compiled it locally to close that gap: Clean — no errors, no new warnings in This is a general property of the repo rather than a problem with this PR: any future change to feature-gated code lands unverified by machine. Worth a The fix itself is right for gominimal/inbox#390: the row advertised a path for a command this build does not ship, and gating it at the same feature that gates the command keeps the two from drifting apart again. |
Routing-Key: inbox-route/I_kwDOSUhdos8AAAABKmgrag
min dirslisted a "Mesh enrolment" row in every build, yet the meshsubcommands compile only under the
remote-accessfeature (off bydefault) — so in a default build
min meshis an unrecognizedsubcommand while
min dirsstill advertised its path, and the row alsosilently switched from the Config group to State under
--minimal-dir.Gating the row, its group selection, and the mesh-enrolment path lookup
behind
remote-accessshows it only when the mesh commands exist, whichalso stops it relocating between groups.
Verification
cargo fmt --all --check— cleancargo clippy --workspace --locked -- -D warnings— 0 warningscargo build --workspace --locked— okcargo test --workspace --locked— ok (minimal crate: 165 passed, 0 failed)Note
Gate the Mesh enrolment row in
dirsbehind theremote-accessfeature flagThe
DirsLookupstruct,MeshGrouptype, and related row-building logic incrates/minimal/src/dirs.rsare now compiled only when theremote-accessfeature is enabled. Builds without the feature omit the Mesh enrolment row from the dirs report output entirely. Tests are updated to conditionally expect the Mesh row based on the feature flag.Macroscope summarized 8cde98c.