Skip to content

chore: scrub private-repo references ahead of open-sourcing #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norrietaylor merged 1 commit into from
Jul 28, 2026
Merged

chore: scrub private-repo references ahead of open-sourcing #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/decode/src/builds.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,8 +701,8 @@ pub struct BuildDecl {
/// `None` means the build-decl did not explicitly declare a target and should
/// be hydrated with the target of whatever graph is being constructed from it.
/// This happens at the decode→graph seam in `graph::BuildSpec::from_decoded`,
/// which consults `Loader::for_target`. See gominimal/infra#18 for the arm64
/// res-server dispatch bug that motivated moving this from eager to deferred.
/// which consults `Loader::for_target`. Moved from eager to deferred to fix
/// an arm64 dispatch bug where the target was resolved before it was known.
pub target: Option<Target>,
/// Any attributes explicitly set on this build-decl.
pub attrs: Option<IndexMap<String, AttrValue>>,
Expand Down
4 changes: 2 additions & 2 deletions scripts/bulk-upload-e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# rate to 50%. Any single failure fails the whole run.
#
# #869 also sometimes HANGS the client outright rather than erroring
# (https://github.com/gominimal/inbox/issues/335, observed at 9 and 13 minutes),
# (observed at 9 and 13 minutes),
# so every activate runs under a wall-clock deadline and a hang counts as a
# failure. A hang also stops the loop — five deadlines back to back would burn
# the nightly's whole job budget, and one is already conclusive.
Expand Down Expand Up @@ -327,7 +327,7 @@ for i in $(seq 1 "$ITER"); do
# the run, and folding them into a collapsed group buries them.
echo "::endgroup::"
if [ "$rc" -eq 124 ]; then
echo "::error::iteration $i: 'min activate' still running after ${DEADLINE_SECS}s — the #869 hang (https://github.com/gominimal/inbox/issues/335)"
echo "::error::iteration $i: 'min activate' still running after ${DEADLINE_SECS}s — the #869 hang"
elif [ "$rc" -eq 0 ]; then
echo "::error::iteration $i: activate's last stdout line is not a session UUID: '$sid'"
else
Expand Down