Skip to content

atuin: pkgscan-allow the Hermes plugin's Popen of atuin itself (18.24.8) - #1505

Merged
bryan-minimal merged 1 commit into
mainfrom
atuin-hermes-allow
Nov 16, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
atuin-hermes-allow

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

Unblocks the atuin 18.24.6 -> 18.24.8 update, which pkgscan stopped on a High ProcessSpawn finding.

The finding is a false positive. crates/atuin-common/res/harnesstools/hermes/__init__.py is new in 18.24.7–8: atuin's plugin for the Hermes AI agent, written by atuin maintainer Michelle Tilley in reviewed PRs atuinsh/atuin#4689, #4701 and #4718. atuin hook install hermes copies it into Hermes's plugin directory so the shell commands Hermes runs are recorded in atuin's history.

  • Line 149 subprocess.Popen (High): runs [ATUIN, "hook", "hermes"], atuin's own binary at an absolute path written at install. It uses an argument list (no shell), sends the event as JSON on stdin, sends stdout and stderr to DEVNULL, and has a timeout.
  • Line 151 os.environ (Medium, doesn't gate): that same call's environment, plus atuin's config paths.
  • Nothing else: the file has no urllib, http, socket, base64 or eval. Its only file read is the session file the user names in hermes atuin import <file>.

The stanza is pinned to the file's sha256 (236e7eda…), so any upstream change to the file makes it gate again. A match regrades the finding, never hides it.

An agent drafted this. Allowlist entries are a security decision, so a human should review and merge it (see #1113).

🤖 Generated with Claude Code

….24.8)

pkgscan flagged a High ProcessSpawn in crates/atuin-common/res/harnesstools/hermes/__init__.py,
new in 18.24.7-8 (atuinsh/atuin#4689, #4701, #4718). It runs atuin's own binary with
the hook event on stdin, with no shell and no network. Pinned to the file's sha256.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 13, 2026 23:19
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 20 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 85 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8699533 and cc17f58.

Files selected for processing: 1

  • packages/atuin/pkgscan-allow.toml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 0f4da5b Nov 16, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the atuin-hermes-allow branch November 16, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants