Repository navigation
Update varlock to 1.25.0 (native helper stays 1.24.0) - #1539
Conversation
The updater's 1.25.0 bump 404'd: the recipe fetched
@varlock/native-helper-linux-{x64,arm64} at %{version}, and no 1.25.0
helper exists. varlock 1.25.0 itself still declares the helpers at 1.24.0
(optionalDependencies), so upstream simply didn't re-release them.
- helper_version = "1.24.0", used for both helper URLs and passed to
build.sh as MINIMAL_ARG_HELPER_VERSION; the helper sha256s are unchanged.
- build.sh fails unless varlock's package.json declares
native-helper-linux-<arch> at helper_version, so a later varlock that
moves its helper fails the build instead of pairing with a stale one.
Checked on the real 1.25.0 package.json: passes at 1.24.0 for x64 and
arm64, fails at 1.25.0.
- varlock-1.25.0.tgz sha256 cac51a85...; its sha512 equals npm's
dist.integrity.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 49 minutes for your next included review. View limit details
|
norrietaylor
left a comment
There was a problem hiding this comment.
Scope matches the title. The PR bumps version to 1.25.0 and adds helper_version for the two native-helper Sources. It also adds a build.sh guard that requires varlock's package.json to declare the pinned helper version. Clobber none. git log on packages/varlock shows the previous changes (#1208, #1409, #1117) are intact, and the CVE-2026-111943 comment block and tests did not change. Correctness MINIMAL_ARG_HELPER_VERSION comes from include helper_version and matches the tarball name that build.sh extracts. The guard fails closed. Under set -ex the diagnostic grep in the error branch also exits non-zero, so the build fails in every case. The helper sha256s did not change, which is correct for an unchanged helper version. The %{version} smoke test still checks the varlock version. Not checked I did not fetch the 1.25.0 tarball, so the new sha256 and the declared helper version in its package.json are not verified. The fetch was denied in this environment. I did not build the package.
| # The native helpers are versioned on their own: varlock 1.25.0 still | ||
| # declares @varlock/native-helper-linux-* 1.24.0 (optionalDependencies), and | ||
| # no 1.25.0 helper exists on npm. Keep this equal to what varlock's | ||
| # package.json declares; build.sh fails if it isn't. |
There was a problem hiding this comment.
nit · The comment names varlock 1.25.0 and no 1.25.0 helper. The updater rewrites only the version binding, so the next automated bump leaves this comment on a version that no longer applies. A version-agnostic comment stays true: "varlock can declare an older @varlock/native-helper-linux-* than its own version (optionalDependencies). Keep this equal to what varlock's package.json declares. build.sh fails if it is not."
The updater's 1.25.0 bump 404'd: the recipe fetched
@varlock/native-helper-linux-{x64,arm64} at %{version}, and no 1.25.0
helper exists. varlock 1.25.0 itself still declares the helpers at 1.24.0
(optionalDependencies), so upstream simply didn't re-release them.
build.sh as MINIMAL_ARG_HELPER_VERSION; the helper sha256s are unchanged.
native-helper-linux- at helper_version, so a later varlock that
moves its helper fails the build instead of pairing with a stale one.
Checked on the real 1.25.0 package.json: passes at 1.24.0 for x64 and
arm64, fails at 1.25.0.
dist.integrity.
Effect on the updater: the helper URLs no longer interpolate
version, so a future varlock bump leaves them alone and lists them under "Additional pinned sources not updated — verify". When varlock does move its helper dependency, this build fails with the declared version, andhelper_versionplus the two helper sha256s are bumped by hand.Replaces the aborted pkgmgr update (
download failed with status 404).🤖 Generated with Claude Code