Skip to content

Update varlock to 1.25.0 (native helper stays 1.24.0) - #1539

Merged
bryan-minimal merged 1 commit into
mainfrom
varlock-1.25.0
Nov 17, 2026
Merged

bryan-minimal merged 1 commit into
mainfrom
varlock-1.25.0

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

The updater's 1.25.0 bump 404'd: the recipe fetched
@varlock/native-helper-linux-{x64,arm64} at %{version}, and no 1.25.0
helper exists. varlock 1.25.0 itself still declares the helpers at 1.24.0
(optionalDependencies), so upstream simply didn't re-release them.

  • helper_version = "1.24.0", used for both helper URLs and passed to
    build.sh as MINIMAL_ARG_HELPER_VERSION; the helper sha256s are unchanged.
  • build.sh fails unless varlock's package.json declares
    native-helper-linux- at helper_version, so a later varlock that
    moves its helper fails the build instead of pairing with a stale one.
    Checked on the real 1.25.0 package.json: passes at 1.24.0 for x64 and
    arm64, fails at 1.25.0.
  • varlock-1.25.0.tgz sha256 cac51a85...; its sha512 equals npm's
    dist.integrity.

Effect on the updater: the helper URLs no longer interpolate version, so a future varlock bump leaves them alone and lists them under "Additional pinned sources not updated — verify". When varlock does move its helper dependency, this build fails with the declared version, and helper_version plus the two helper sha256s are bumped by hand.

Replaces the aborted pkgmgr update (download failed with status 404).

🤖 Generated with Claude Code

The updater's 1.25.0 bump 404'd: the recipe fetched
@varlock/native-helper-linux-{x64,arm64} at %{version}, and no 1.25.0
helper exists. varlock 1.25.0 itself still declares the helpers at 1.24.0
(optionalDependencies), so upstream simply didn't re-release them.

- helper_version = "1.24.0", used for both helper URLs and passed to
  build.sh as MINIMAL_ARG_HELPER_VERSION; the helper sha256s are unchanged.
- build.sh fails unless varlock's package.json declares
  native-helper-linux-<arch> at helper_version, so a later varlock that
  moves its helper fails the build instead of pairing with a stale one.
  Checked on the real 1.25.0 package.json: passes at 1.24.0 for x64 and
  arm64, fails at 1.25.0.
- varlock-1.25.0.tgz sha256 cac51a85...; its sha512 equals npm's
  dist.integrity.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal requested a review from a team as a code owner November 16, 2026 18:39
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 2 billable files and costs up to $0.50.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 49 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 79 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between ca566dc and ce96bb6.

Files selected for processing: 2

  • packages/varlock/build.ncl
  • packages/varlock/build.sh
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@norrietaylor norrietaylor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope matches the title. The PR bumps version to 1.25.0 and adds helper_version for the two native-helper Sources. It also adds a build.sh guard that requires varlock's package.json to declare the pinned helper version. Clobber none. git log on packages/varlock shows the previous changes (#1208, #1409, #1117) are intact, and the CVE-2026-111943 comment block and tests did not change. Correctness MINIMAL_ARG_HELPER_VERSION comes from include helper_version and matches the tarball name that build.sh extracts. The guard fails closed. Under set -ex the diagnostic grep in the error branch also exits non-zero, so the build fails in every case. The helper sha256s did not change, which is correct for an unchanged helper version. The %{version} smoke test still checks the varlock version. Not checked I did not fetch the 1.25.0 tarball, so the new sha256 and the declared helper version in its package.json are not verified. The fetch was denied in this environment. I did not build the package.

# The native helpers are versioned on their own: varlock 1.25.0 still
# declares @varlock/native-helper-linux-* 1.24.0 (optionalDependencies), and
# no 1.25.0 helper exists on npm. Keep this equal to what varlock's
# package.json declares; build.sh fails if it isn't.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit · The comment names varlock 1.25.0 and no 1.25.0 helper. The updater rewrites only the version binding, so the next automated bump leaves this comment on a version that no longer applies. A version-agnostic comment stays true: "varlock can declare an older @varlock/native-helper-linux-* than its own version (optionalDependencies). Keep this equal to what varlock's package.json declares. build.sh fails if it is not."

@bryan-minimal
bryan-minimal added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit eaabbf3 Nov 17, 2026
15 checks passed
@bryan-minimal
bryan-minimal deleted the varlock-1.25.0 branch November 17, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants