Update TCL and Railway - #498
Conversation
📝 WalkthroughWalkthroughThe Railway package updates its CLI release and checksum. The Tcl package updates to version 8.6.18, passes the version into its build script, parameterizes source extraction, and derives bundled tdbc and itcl versions for configuration rewrites. ChangesPackage build updates
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/railway/build.ncl`:
- Line 9: Update the build configuration around the declared version in
build.ncl by adding build_args that includes version, ensuring build.sh receives
the same value instead of a separately hardcoded version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 900645d7-7f2e-44af-a52b-a6eb605289d7
📒 Files selected for processing (1)
packages/railway/build.ncl
| let glibc = import "../glibc/build.ncl" in | ||
|
|
||
| let version = "4.30.2" in | ||
| let version = "5.27.2" in |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Forward version to build.sh.
Add build_args = { include version } so the build script receives the same version declared here instead of requiring a separately hardcoded value.
Proposed change
let version = "5.27.2" in
{
name = "railway",
+ build_args = { include version },As per coding guidelines, declared versions must be forwarded through build_args.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| let version = "5.27.2" in | |
| let version = "5.27.2" in | |
| { | |
| name = "railway", | |
| build_args = { include version }, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/railway/build.ncl` at line 9, Update the build configuration around
the declared version in build.ncl by adding build_args that includes version,
ensuring build.sh receives the same value instead of a separately hardcoded
version.
Source: Coding guidelines
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/tcl/build.sh`:
- Around line 4-5: Update the Tcl build configuration in build.ncl to add the
tar package to build_deps, and change the archive extraction command in the
build script from tar -xof to tar -xf. Keep the existing archive and directory
targets unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bd48dd67-ebe5-4768-b4d8-c7b617db697e
📒 Files selected for processing (2)
packages/tcl/build.nclpackages/tcl/build.sh
| tar -xof tcl$MINIMAL_ARG_VERSION-src.tar.gz | ||
| cd tcl$MINIMAL_ARG_VERSION |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Declare tar as an explicit build dependency.
This script invokes tar, but packages/tcl/build.ncl does not list a tar package in build_deps. Add that dependency and use tar -xf here to keep the build self-contained.
As per coding guidelines, manually extracted tarballs must declare tar in build_deps and use tar -xf.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/tcl/build.sh` around lines 4 - 5, Update the Tcl build configuration
in build.ncl to add the tar package to build_deps, and change the archive
extraction command in the build script from tar -xof to tar -xf. Keep the
existing archive and directory targets unchanged.
Source: Coding guidelines
Did locally, check passed
Summary by CodeRabbit