Skip to content

fix(claude-code): do not upload .claude to new sessions - #503

Merged
twitchyliquid64 merged 1 commit into
mainfrom
tom/claude
Jul 21, 2026
Merged

fix(claude-code): do not upload .claude to new sessions#503
twitchyliquid64 merged 1 commit into
mainfrom
tom/claude

Conversation

@twitchyliquid64

@twitchyliquid64 twitchyliquid64 commented Jul 21, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

As discussed online (offline?)

Summary by CodeRabbit

  • Documentation
    • Clarified that .claude.json stores Anthropic credentials.
    • Removed documentation for the obsolete .claude state directory mapping.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23329c53-86eb-491e-acb3-466de0ea840e

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc7299 and 7ea20a4.

📒 Files selected for processing (1)
  • packages/claude-code/build.ncl
📝 Walkthrough

Walkthrough

The Claude Code package mapping now documents .claude.json as containing Anthropic credentials and removes the previous ~/.claude state directory mapping.

Changes

Claude Code mappings

Layer / File(s) Summary
Credential mapping cleanup
packages/claude-code/build.ncl		 The .claude.json credential file mapping remains, while the ~/.claude state directory mapping is removed and the credential comment is updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: evanspearman, bryan-minimal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: preventing the .claude directory from being uploaded to new sessions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tom/claude

Comment @coderabbitai help to get the list of available commands.

@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit a6f7935 Jul 21, 2026
10 checks passed
@twitchyliquid64
twitchyliquid64 deleted the tom/claude branch July 21, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanspearman evanspearman evanspearman approved these changes
@bryan-minimal bryan-minimal Awaiting requested review from bryan-minimal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twitchyliquid64 @evanspearman