Skip to content

graphviz: single slash in the mirror URL - #516

Merged
twitchyliquid64 merged 1 commit into
mainfrom
fix-graphviz-double-slash
Jul 23, 2026
Merged

graphviz: single slash in the mirror URL#516
twitchyliquid64 merged 1 commit into
mainfrom
fix-graphviz-double-slash

Conversation

@bryan-minimal

Copy link
Copy Markdown
Member

One-character fix unblocking the graphviz 14.1.1 → 15.1.0 update dropped from pkgs#515.

The gs:// URL carried a double slash after the bucket. Fetches tolerated it (the object lives at the clean name — verified 200, and no slash-prefixed twin exists), but the updater derives the GCS object path from this URL and got /graphviz-15.1.0.tar.bz2, which its path-traversal guard correctly rejects. Guard right, data typo'd.

Swept packages/ for the class: only instance.

After merge, the next update run should carry graphviz 15.1.0 normally.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9df523e9-97ca-4c82-bcde-ef92d872576d

📥 Commits

Reviewing files that changed from the base of the PR and between c027f54 and aa49cb5.

📒 Files selected for processing (1)
  • packages/graphviz/build.ncl
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-graphviz-double-slash

Comment @coderabbitai help to get the list of available commands.

The gs:// URL carried a double slash after the bucket:

    gs://minimal-staging-archives//graphviz-%{version}.tar.bz2

The fetch path happened to tolerate it (the object lives at the clean
single-slash name and builds succeeded), but the UPDATER derives the
GCS object path from this URL and got "/graphviz-15.1.0.tar.bz2" —
which its path-traversal guard correctly rejects (leading slash), so
the 14.1.1 -> 15.1.0 update was dropped from pkgs#515 with
"invalid GCS path". The guard is right; the data was typo'd.

Verified: graphviz-14.1.1.tar.bz2 exists at the single-slash name
(HTTP 200) and no object exists under the slash-prefixed name, so this
cannot break the current fetch. Swept all of packages/ for the class:
this was the only instance.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bryan-minimal
bryan-minimal force-pushed the fix-graphviz-double-slash branch from 81d4bd4 to aa49cb5 Compare July 23, 2026 20:09
@twitchyliquid64
twitchyliquid64 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit 108ee14 Jul 23, 2026
9 checks passed
@twitchyliquid64
twitchyliquid64 deleted the fix-graphviz-double-slash branch July 23, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants